[yoda-svn] yoda: CHANGELOG: Fix setVal(i, x) numbered-axis methods on Point...

YODA Mercurial yoda at projects.hepforge.org
Wed Aug 16 18:00:02 BST 2017


details:   https://yoda.hepforge.org/hg/yoda/rev/b04b86663405
branches:  release-1-6
changeset: 1366:b04b86663405
user:      Andy Buckley <andy at insectnation.org>
date:      Wed Aug 16 17:46:53 2017 +0100
description:
CHANGELOG: Fix setVal(i, x) numbered-axis methods on Point2D and Point3D: switch break statements were missing.

diffs (truncated from 308 to 50 lines):

--- a/ChangeLog	Wed Aug 16 12:55:41 2017 +0100
+++ b/ChangeLog	Wed Aug 16 17:46:53 2017 +0100
@@ -1,5 +1,8 @@
 2017-08-16  Andy Buckley  <andy.buckley at cern.ch>
 
+	* Fix setVal(i, x) numbered-axis methods on Point2D and Point3D:
+	switch break statements were missing.
+
 	* Explicitly load all ROOT objects as a list rather than
 	generator. Patch from Dmitry Kalinkin.
 
--- a/include/YODA/Point1D.h	Wed Aug 16 12:55:41 2017 +0100
+++ b/include/YODA/Point1D.h	Wed Aug 16 17:46:53 2017 +0100
@@ -202,71 +202,71 @@
     }
     /// Set the point value for direction @a i
     void setVal(size_t i, double val) {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");
+      if (i != 1) throw RangeError("Invalid axis int, must be in range 1..dim");
       setX(val);
     }
 
     /// Get error values for direction @a i
     const std::pair<double,double>& errs(size_t i) const {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");
+      if (i != 1) throw RangeError("Invalid axis int, must be in range 1..dim");
       return xErrs();
     }
     /// Get negative error value for direction @a i
     double errMinus(size_t i) const {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");
+      if (i != 1) throw RangeError("Invalid axis int, must be in range 1..dim");
       return xErrMinus();
     }
     /// Get positive error value for direction @a i
     double errPlus(size_t i) const {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");
+      if (i != 1) throw RangeError("Invalid axis int, must be in range 1..dim");
       return xErrPlus();
     }
     /// Get average error value for direction @a i
     double errAvg(size_t i) const {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");
+      if (i != 1) throw RangeError("Invalid axis int, must be in range 1..dim");
       return xErrAvg();
     }
 
     /// Set negative error for direction @a i
     void setErrMinus(size_t i, double eminus) {
-      if (i == 0 || i > 1) throw RangeError("Invalid axis int, must be in range 1..dim");


More information about the yoda-svn mailing list