|
[Rivet] Move bootstrap into main repository for versioning?David Grellscheid david.grellscheid at durham.ac.ukMon Feb 10 09:25:16 GMT 2014
> Anything left to do / surprises from clang static analyzer, David? No, all the GBs of temporary files collapsed down to two minor question marks: CMS_2013_I1258128.cc I don't get the logic here. What is this filter trying to achieve? This will need to be checked against the paper: > 111 // Clean the jets against the photon candidate with a DeltaR cut of 0.5 > 112 std::vector<const Jet*> cleanedJets; > 113 foreach (const Jet& j, jets) { > 114 bool isolated = true; > 115 if (deltaR(photon.momentum(), j.momentum()) < 0.5) { > 116 isolated = false; > ====== Value stored to 'isolated' is never read ======= > 117 break; > 118 } > 119 if (isolated) cleanedJets.push_back(&j); > 120 } > 121 // Require exactly 1 jet > 122 if (cleanedJets.size() != 1) return; And an unused variable here: ATLAS_2012_I1180197.cc > 216 // both selections require at least 2 jets > 217 // meff calculation > 218 double HT=0.; > 219 foreach( const Jet & jet, recon_jets) { > 220 HT += jet.momentum().perp(); > 221 } > 222 double m_eff_inc = HT+eTmiss; > 223 unsigned int njet = recon_jets.size(); > 224 // 1 lepton only > 225 if( recon_hard_e.size() + recon_hard_mu.size() == 1 && njet >=3 ) { > 226 // get the lepton > 227 Particle lepton = recon_hard_e.empty() ? > 228 recon_hard_mu[0] : recon_hard_e[0]; > 229 // lepton variables > 230 double pT = lepton.momentum().perp(); > 231 double mT = 2.*(pT*eTmiss - > 232 lepton.momentum().x()*pTmiss.x() - > 233 lepton.momentum().y()*pTmiss.y()); > 234 mT = sqrt(mT); > 235 HT += pT; > ====== Value stored to 'HT' is never read ======= > 236 m_eff_inc += pT;
More information about the Rivet mailing list |