[Rivet] [Rivet-svn] r2850 - in trunk: . bin pyext

[Andy Buckley]

On 25/02/11 23:28, Frank Siegert wrote:
> Hi Andy,
> 
>> Author: buckley
>> Date: Thu Dec 16 17:06:03 2010
>> New Revision: 2850
>>
>> Log:
>> Various small improvements to histo parsing, histo paths, plot files,
>> etc.
>>
>> Modified: trunk/pyext/lighthisto.py
>> ==============================================================================
>>
>> --- trunk/pyext/lighthisto.py    Tue Dec 14 11:47:37 2010    (r2849)
>> +++ trunk/pyext/lighthisto.py    Thu Dec 16 17:06:03 2010    (r2850)
>> @@ -553,10 +550,12 @@
>>                           vm = self.pat_property.match(line)
>>                           if vm:
>>                               prop, value = vm.group(1,2)
>> +                            #print prop, value
>>                               ret[section][prop] = value
>>                       elif section in ['SPECIAL']:
>>                           ret[section] += line
>>                   f.close()
>> +                break
>>           return ret[section]
>>
>>
> 
> Without this "break" it would allow for local overwriting of histogram
> options. Use case: I want to plot the Z pT in the MC_ZJETS analysis,
> which extends from 1 GeV to sqrt(s)/2. For some reason I only want to
> plot from 1 GeV to 100 GeV in my current setup. I could now copy all the
> settings for /MC_ZJETS/Z_pT from MC_ZJETS.plot into a local
> MC_ZJETS.plot file and add my XMin and XMax. But I'd prefer to only have
> to add a MC_ZJETS.plot containing my XMin and XMax, i.e. all options
> which I don't specify there should be taken from the default plotting file.
> Does that make sense? Any objections to recreating the old behaviour?

Perfect sense. Can you add a comment to that effect to stop me deleting
it again? ;)

> PS: I think this should be the last one from my side, do we release on
> Monday or have I overlooked something? I need to install this for a
> school soon, and would like to use the 1.5.0 release.

I think we're about ready to go. The ATLAS cluster UE is apparently
close to release, but we have to draw a line somewhere and your school
requirement gives a motivation to do it on Monday.

* Holger, can you please get your UA5 correlation analysis' errors fixed
for Monday?
* Hendrik, we should coordinate the compare-histos styles option work: I
can do it if you want to concentrate on getting more CMS analyses ready.
* Any other remaining unticketed to-dos?
* If I get very bored at the weekend I might unify the .info files'
declared beam types and energies with the analysis info object, and use
both to determine analysis/run compatibility. I've wanted to do it for a
while, and now seems a good enough time.

I'm going to be pretty busy on Monday, but will have free time in the
evening. Do you need it earlier than that, Frank? -- it can be done if
required.

Andy

-- 
Dr Andy Buckley
SUPA Advanced Research Fellow
Particle Physics Experiment Group, University of Edinburgh

The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.