[Rivet] aida2root

[Ben Waugh]

Hi Andy,

On 07/10/09 11:01, Andy Buckley wrote:
> Ben Waugh wrote:
>> Hi Andy, All,
>>
>> Looks like this fix, and the clearer warning message, has got lost
>> somewhere along the way, since the tagged release rivet-1.1.3 has
>> os.has_key("ROOTSYS")
>> instead of
>> if os.environ.has_key("ROOTSYS")
>> in aida2root.
>>
>> Can it please be fixed again in the next tagged version?
>
> Bizarre! I've no idea how that managed to not make it into the release.
> It'll definitely be correct in the next release.

D'oh. Of course this release was tagged before the fix. I was confused 
by the fact that version 1.1.3 has been modified after it was tagged, 
but presumably only the build stuff rather than the source code itself.

Now I'm even more confused though. Probably due to an incorrect blood 
caffeine level or maybe BSE, but at the risk of embarrassment...

It seems that the version of "aida2root" in Svn as 
tags/rivet-1.1.3/bin/aida2root is completely different from the version 
in the tarball Rivet-1.1.3.tar.gz that is downloaded by the bootstrap 
script. The version in the tarball looks familiar and has the (albeit 
incorrect) check on $ROOTSYS, but the version in Svn does not.

Is this also related to changes in the code since the tag was created? 
Should we perhaps add a patch number to the end of the Rivet release 
number so we know exactly which version of the code (and build scripts) 
we are really using?

Anyway, in this case the problem is fixed in the trunk.

Cheers,
Ben

-- 
Dr Ben Waugh                                   Tel. +44 (0)20 7679 7223
Dept of Physics and Astronomy                  Internal: 37223
University College London
London WC1E 6BT