[Rivet-svn] rivet: 3 new changesets

[Rivet Mercurial]

details:   https://rivet.hepforge.org/hg/rivet/rev/4f28f58d951a
branches:  
changeset: 6134:4f28f58d951a
user:      Andy Buckley <andy at insectnation.org>
date:      Tue Nov 07 00:24:44 2017 +0000
description:
Improve PF doc and fix a bug introduced by interface change

details:   https://rivet.hepforge.org/hg/rivet/rev/f9e7c994c768
branches:  
changeset: 6135:f9e7c994c768
user:      Andy Buckley <andy at insectnation.org>
date:      Tue Nov 07 00:25:13 2017 +0000
description:
Remove debug printouts

details:   https://rivet.hepforge.org/hg/rivet/rev/21229234ba24
branches:  
changeset: 6136:21229234ba24
user:      Andy Buckley <andy at insectnation.org>
date:      Mon Nov 13 14:44:31 2017 +0000
description:
Fix a few issues resulting from change of particles() meaning on W/ZFinder, plus opportunistic tidying

diffs (truncated from 876 to 50 lines):

--- a/analyses/pluginATLAS/ATLAS_2011_I925932.cc	Mon Nov 06 20:23:01 2017 +0000
+++ b/analyses/pluginATLAS/ATLAS_2011_I925932.cc	Mon Nov 13 14:44:31 2017 +0000
@@ -1,17 +1,16 @@
 // -*- C++ -*-
-// ATLAS W pT analysis
-
 #include "Rivet/Analysis.hh"
 #include "Rivet/Projections/WFinder.hh"
 
 namespace Rivet {
 
 
+  /// ATLAS W pT analysis
   class ATLAS_2011_I925932 : public Analysis {
   public:
 
     /// Constructor
-    ATLAS_2011_I925932() : Analysis("ATLAS_2011_I925932") {  }
+    DEFAULT_RIVET_ANALYSIS_CTOR(ATLAS_2011_I925932);
 
 
     /// @name Analysis methods
@@ -54,15 +53,17 @@
       }
 
       // "Dressed" electron
-      if (!wfinder_dressed_el.particles().empty()) {
-	    const FourMomentum& nu = wfinder_dressed_el.constituentNeutrinos()[0].momentum();
+      if (!wfinder_dressed_el.empty()) {
+        /// @todo Is this safe? Using MET would be better
+	    const FourMomentum& nu = wfinder_dressed_el.constituentNeutrinos()[0];
 	    if (wfinder_dressed_el.mT() > 40*GeV && nu.pT() > 25*GeV) {
           _hist_wpt_dressed_el->fill(wfinder_dressed_el.bosons()[0].pT()/GeV, weight);
 	    }
       }
 
       // "Bare" electron
-      if (!wfinder_bare_el.particles().empty()) {
+      if (!wfinder_bare_el.empty()) {
+        /// @todo Is this safe? Using MET would be better
 	    const FourMomentum& nu = wfinder_bare_el.constituentNeutrinos()[0].momentum();
 	    if (wfinder_bare_el.mT() > 40*GeV && nu.pT() > 25*GeV) {
           _hist_wpt_bare_el->fill(wfinder_bare_el.bosons()[0].pT()/GeV, weight);
@@ -70,7 +71,8 @@
       }
 
       // "Dressed" muon
-      if (!wfinder_dressed_mu.particles().empty()) {
+      if (!wfinder_dressed_mu.empty()) {
+        /// @todo Is this safe? Using MET would be better