[Rivet-svn] rivet: Core is compiling again, but make check has 3 failures.

[Rivet Mercurial]

details:   https://rivet.hepforge.org/hg/rivet/rev/8d919630cb2e
branches:  multiweight
changeset: 5584:8d919630cb2e
user:      Chris Pollard <cspollard at gmail.com>
date:      Wed Oct 26 15:08:15 2016 +0100
description:
Core is compiling again, but make check has 3 failures.

diffs (truncated from 805 to 50 lines):

--- a/include/Rivet/Analysis.hh	Wed Oct 26 14:15:34 2016 +0100
+++ b/include/Rivet/Analysis.hh	Wed Oct 26 15:08:15 2016 +0100
@@ -375,14 +375,14 @@
     //@{
 
     /// Book a counter.
-    CounterPtr bookCounter(const std::string& name,
+    CounterPtr& bookCounter(const std::string& name,
                            const std::string& title="");
                            // const std::string& valtitle=""
 
     /// Book a counter, using a path generated from the dataset and axis ID codes
     ///
     /// The paper, dataset and x/y-axis IDs will be used to build the histo name in the HepData standard way.
-    CounterPtr bookCounter(unsigned int datasetId, unsigned int xAxisId, unsigned int yAxisId,
+    CounterPtr& bookCounter(unsigned int datasetId, unsigned int xAxisId, unsigned int yAxisId,
                            const std::string& title="");
                            // const std::string& valtitle=""
 
@@ -393,28 +393,28 @@
     //@{
 
     /// Book a 1D histogram with @a nbins uniformly distributed across the range @a lower - @a upper .
-    Histo1DPtr bookHisto1D(const std::string& name,
+    Histo1DPtr& bookHisto1D(const std::string& name,
                            size_t nbins, double lower, double upper,
                            const std::string& title="",
                            const std::string& xtitle="",
                            const std::string& ytitle="");
 
     /// Book a 1D histogram with non-uniform bins defined by the vector of bin edges @a binedges .
-    Histo1DPtr bookHisto1D(const std::string& name,
+    Histo1DPtr& bookHisto1D(const std::string& name,
                            const std::vector<double>& binedges,
                            const std::string& title="",
                            const std::string& xtitle="",
                            const std::string& ytitle="");
 
     /// Book a 1D histogram with binning from a reference scatter.
-    Histo1DPtr bookHisto1D(const std::string& name,
+    Histo1DPtr& bookHisto1D(const std::string& name,
                            const Scatter2D& refscatter,
                            const std::string& title="",
                            const std::string& xtitle="",
                            const std::string& ytitle="");
 
     /// Book a 1D histogram, using the binnings in the reference data histogram.
-    Histo1DPtr bookHisto1D(const std::string& name,
+    Histo1DPtr& bookHisto1D(const std::string& name,
                            const std::string& title="",