[Rivet-svn] rivet: Downgrade some non-fatal error messages from ERROR to WAR...

[Rivet Mercurial]

details:   https://rivet.hepforge.org/hg/rivet/rev/79594d081527
branches:  release-2-4-x
changeset: 5231:79594d081527
user:      Andy Buckley <andy at insectnation.org>
date:      Thu Jun 09 14:40:48 2016 +0100
description:
Downgrade some non-fatal error messages from ERROR to WARNING status, because *sigh* ATLAS's software treats any appearance of the word 'ERROR' in its log file as a reason to report the job as failed (facepalm).

diffs (38 lines):

--- a/ChangeLog	Tue Jun 07 16:32:38 2016 +0100
+++ b/ChangeLog	Thu Jun 09 14:40:48 2016 +0100
@@ -1,3 +1,10 @@
+2016-06-09  Andy Buckley  <andy.buckley at cern.ch>
+
+	* Downgrade some non-fatal error messages from ERROR to WARNING
+	status, because *sigh* ATLAS's software treats any appearance of
+	the word 'ERROR' in its log file as a reason to report the job as
+	failed (facepalm).
+
 2016-06-07  Andy Buckley  <andy.buckley at cern.ch>
 
 	* Adding ATLAS 13 TeV minimum bias analysis, ATLAS_2016_I1419652.
--- a/src/Core/Analysis.cc	Tue Jun 07 16:32:38 2016 +0100
+++ b/src/Core/Analysis.cc	Thu Jun 09 14:40:48 2016 +0100
@@ -665,7 +665,7 @@
 
   void Analysis::normalize(Histo1DPtr histo, double norm, bool includeoverflows) {
     if (!histo) {
-      MSG_ERROR("Failed to normalize histo=NULL in analysis " << name() << " (norm=" << norm << ")");
+      MSG_WARNING("Failed to normalize histo=NULL in analysis " << name() << " (norm=" << norm << ")");
       return;
     }
     MSG_TRACE("Normalizing histo " << histo->path() << " to " << norm);
@@ -680,11 +680,11 @@
 
   void Analysis::scale(Histo1DPtr histo, double scale) {
     if (!histo) {
-      MSG_ERROR("Failed to scale histo=NULL in analysis " << name() << " (scale=" << scale << ")");
+      MSG_WARNING("Failed to scale histo=NULL in analysis " << name() << " (scale=" << scale << ")");
       return;
     }
     if (std::isnan(scale) || std::isinf(scale)) {
-      MSG_ERROR("Failed to scale histo=" << histo->path() << " in analysis: " << name() << " (invalid scale factor = " << scale << ")");
+      MSG_WARNING("Failed to scale histo=" << histo->path() << " in analysis: " << name() << " (invalid scale factor = " << scale << ")");
       scale = 0;
     }
     MSG_TRACE("Scaling histo " << histo->path() << " by factor " << scale);