[Rivet-svn] r1906 - trunk/include/Rivet

blackhole at projects.hepforge.org blackhole at projects.hepforge.org
Wed Oct 14 16:56:54 BST 2009


Author: fsiegert
Date: Wed Oct 14 16:56:54 2009
New Revision: 1906

Log:
I can't see any reason for this @todo, so have fixed it and wait until
somebody complains (I am using this method in ATLAS by the way, so don't
remove it completely ;-)).

Modified:
   trunk/include/Rivet/AnalysisHandler.hh

Modified: trunk/include/Rivet/AnalysisHandler.hh
==============================================================================
--- trunk/include/Rivet/AnalysisHandler.hh	Wed Oct 14 13:32:23 2009	(r1905)
+++ trunk/include/Rivet/AnalysisHandler.hh	Wed Oct 14 16:56:54 2009	(r1906)
@@ -100,13 +100,10 @@
     AnalysisHandler& removeAnalyses(const std::vector<std::string>& analysisnames);
 
 
-    /// Add an analysis to the run list by supplying a "template" analysis.
-    /// @todo Is there a good reason to not allow "direct" submission?
-    template <typename A>
-    AnalysisHandler& addAnalysis(const A& analysis) {
-      A* a = new A(analysis);
-      a->_analysishandler = this;
-      _analyses.insert(a);
+    /// Add an analysis to the run list explicitely
+    AnalysisHandler& addAnalysis(Analysis* analysis) {
+      analysis->_analysishandler = this;
+      _analyses.insert(analysis);
       return *this;
     }
 


More information about the Rivet-svn mailing list